Original Post
I sometimes wonder if my coding style is totally idiosuncratic, understandable only by me, or if I could give my code to someone else and have them read it. So I'm asking you to judge - do I need to change? Here's an example picked at random from the project I'm working on : [Edited by - King of Men on April 7, 2005 12:49:32 PM]
private void updateCross () {
crossection = 0;
for (int i = 0; i < moduleGeometry.length; i++) {
for (int j = 0; j < moduleGeometry[0].length; j++) {
for (int k = 0; k < moduleGeometry[0][0].length; k++) {
crossection += moduleGeometry[j][k].getCrossSection();
}
}
}
}
private void fire() {
// Order of ships : First the assigned target, then
// the detected ones in order of detection. Sorting
// already done in detect method. For each ship, try
// to assign each weapon to fire at it.
if (targetShip != -1) {
fireAt(targetShip);
}
for (int i = 0; i < detectedShips.length; i++) {
if (detectedShips != -1) fireAt(detectedShips);
}
}
private void fireAt (int target) {
Vector3d forward = new Vector3d(Math.cos(myAngle), 0, Math.sin(myAngle));
Vector3d toTarget = new Vector3d(allShips[target].position.x - position.x, 0, allShips[target].position.z - position.z);
for (int i = 0; i < myGuns.length; i++) {
if (myGuns.canFire(forward, toTarget)) {
// TODO : May want to consider things like volley fire, etc - hence
// separate method for canFire and doFire.
myGuns.fireAt(allShips[target]);
}
}
}
