std::string bug?

Quote:

MSDN page: Objects of type string belonging to the C++ template class basic_string are not necessarily null terminated. The null character ' \0 ' is used as a special character in a C-string to mark the end of the string but has not special meaning in an object of type string and may be a part of the string just like any other character.

Quote:

Original post by paulecoyote a stl string does not have to be terminated by the \x00 character, but then you do actually have to tell it what size it should be..

std::string foo = "foo";foo[1] = '\0';

Quote:

Original post by ToohrVyk Quote: Original post by paulecoyote a stl string does not have to be terminated by the \x00 character, but then you do actually have to tell it what size it should be.. std::string foo = "foo";foo[1] = '\0'; Now foo is the string made of the characters f, \0, o (in that order).

Quote:

Original post by paulecoyote I meant if you used strcpy or something like that that uses null terminating characters as a stop. What you've done there is declare something with 3 elements and change the 2nd one, so that is bound to work.

Quote:

Original post by kristoferos Thanks for all of your replies, passing the length as an argument worked but how would I be able to get the length of the big strings that change all the time?

Quote:

Original post by paulecoyote *sigh* Code:

Quote:

Original post by SiCrane Quote: Original post by paulecoyote *sigh* Code: All that code proves is that you don't understand the term "copy constructor". A copy constructor is a constructor for a class X that takes as an argument a cv qualified reference to X. That's it, no other constructor for a class X is a copy constructor. Devja already posted the correct way to create a std::string from a non-null terminated pointer to a char array. My statement was directed exclusively at your post about the strcpy() function, which still stands.

const char* testString=("abcd\x00 efghijk");		cout << "testString: " << testString << endl;		std::string nullTest;                // Just for SiCrane		nullTest = (testString);		if (4==nullTest.length())		{			cout << "Well looks like only the first bit of the string was copied across, just like I was trying to say all along: " << nullTest << endl;		}		else		{			cout << "All the string was copied, my bad." << endl;		}		std::string nullTest2;		nullTest2.resize(13);		nullTest2.assign( testString, 13);				if ((13==nullTest2.length()) && ('k'==nullTest2[12]))		{			cout << "Well looks like the whole string was copied this time, because you told it what size it should be and used assign to tell it how many characters to copy: " << nullTest2 << endl;		}		else		{			cout << "Not all the string was copied, my bad." << endl;		}

Quote:

Original post by paulecoyote but then you do actually have to tell it what size it should be.

Quote:

Original post by Deyjastd::string(string_with_nulls,length)

Quote:

Original post by kristoferos Thanks for all of your replies, passing the length as an argument worked

Quote:

Original post by SiCranestd::string has a perfectly usable copy constructor and assignment operator.

Quote:

Original post by paulecoyote changed the one line to use the copy constructor, rather then just the constructor. Code still has same output.

Quote:

But I stand by what I was saying in that passing a c-style string to an stl string copy contructor with null terminating characters in won't work, as that code fragment was trying to illustrate.

Quote:

Original post by paulecoyote As you see (and probably know) SiCrane, when you have nulls embedded in a c-style string using the std::string copy constructor still does not copy across the whole string.

Quote:

changed the one line to use the copy constructor, rather then just the constructor. Code still has same output.

std::string a( 10, '\0' );std::string b(a); // copy constructorstd::string c = "foo!";c = a; // assignment operator

const char* cStyleString=("abcd\x00 efghijk");//Constructor: std::string(char const *)std::string string(cStyleString);//Not a copy-constructor.  Exactly the same as the above constructor: std::string(char const *)std::string string2 = cStyleString;//Default constructor: std::string()std::string string3;//Assignment operator: std::string & operator=(char const *)string3 = cStyleString;//Copy constructor: std::string(std::string const &)std::string string4(string2);//Copy constructor.  Same as above: std::string(std::string const &)std::string string5 = string2;//Copy assignment operator: std::string & operator=(std::string const &)string5 = string3;

std::string initialString("Hello.\0Goodbye.\0Hello", 21);std::string appendedString = initialString + " again.";// appendedString = "Hello.\0Goodbye.\0Hello again."appendedString.replace(appendedString.find("Goodbye"), 7, "Farewell");// appendedString = "Hello.\0Farewell.\0Hello again."std::cout << appendedString << '\n';// prints "Hello.\0Farewell.\0Hello again.\n"