🔒 Locked

Problem with color when multitexturing

Started by karx11erx Apr 7, 2006 at 2:43 AM 11 replies 1.4k views

Original Post

Apr 7, 2006 at 2:43 AM

Hi, when I am multitexturing a polygon in my program, the overlay texture is always rendered fully bright. How come, how can I fix that? Sample code:


typedef float tVertexf [3];
typedef struct tRGBAf {float r,g,b,a;} tRGBA;
typedef struct tTexCoordf {float u,v;} tTexCoord;

void RenderPoly (GLuint tex1, GLuint tex2, tVertexf *pv, tTexCoordf *ptc, int nv, tRGBAf *pc)
{
glEnable (GL_TEXTURE_2D);
//TMU 0 for base textures
glActiveTexture (GL_TEXTURE0_ARB);
glBindTexture (GL_TEXTURE_2D, tex1);
glEnable (GL_TEXTURE_2D);
glTexEnvf (GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE);
// TMU 1 for overlay texture
glActiveTexture (GL_TEXTURE1_ARB);
glBindTexture (GL_TEXTURE_2D, tex2);
glEnable (GL_TEXTURE_2D);
glTexEnvf (GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_DECAL);
glBegin (GL_TRIANGLE_FAN);
for (; nv; nv--, pv++, ptc++) {
   glMultiTexCoord2f (GL_TEXTURE0_ARB, ptc->u, ptc->v);
   glMultiTexCoord2f (GL_TEXTURE1_ARB, ptc->u, ptc->v);
   glColor4f (pc->r, pc->g, pc->b, pc->a);
   glVertex3f (pv->x, pv->y, pv->z);
   }
glEnd ();
glDisable (GL_TEXTURE_2D);
}

[Edited by - karx11erx on April 7, 2006 10:19:03 AM]

Demus79

Apr 7, 2006 at 3:37 AM

Probably you are modulating the base texture with your diffuse and then adding the second texture on top of it.

You should first blend the base and the second texture together (by alpha or what ever formula you want to use) and the modulate that result with the diffuse.

karx11erx

Apr 7, 2006 at 8:57 AM

Whaaaaaaaaaaaaat? I am trying a simple multitexture using two bitmaps!

Kalidor

Apr 7, 2006 at 9:20 AM

There are a couple things I noticed that seem odd.

First, there is no glBind function. If it's a function you wrote, don't use the gl prefix; that is reserved for OpenGL's use. I'll assume that's actually glBindTexture(GL_TEXTURE_2D, ...) in your code.

Second, glTexEnv when pname is GL_TEXTURE_ENV_COLOR takes a 4-element array in params, not one of OpenGL's constants. I guess you aren't checking for OpenGL errors (you should be) because that would be throwing a GL_INVALID_ENUM error.

Now, what do you mean by "rendered fully bright?" I don't think you mean anything to do with lighting because I don't see any lighting-related function calls in there. Perhaps you could explain the problem a little more and possibly post a screenshot as well?

karx11erx

Apr 7, 2006 at 9:49 AM

The actual code calls glBindTexture.

I don't think prefixing self-written function names with 'gl' does any harm, as long as I don't use a real OpenGL name.

I have removed the erroneous calls to glTexEnv, didn't make a difference.

The application doesn't use any OpenGL lighting functions, everything is done with calls to glColor().

Here's a screenshot: The bright purple texture at the sides should be as dark as the rearward face. If I use GL_MODULATE instead of GL_DECAL for the overlay textures, this works - but then I have cases where the overlay textures gets almost completely merged with the background, instead of clearly standing out.

[Edited by - karx11erx on April 7, 2006 10:49:28 AM]

Kalidor

Apr 7, 2006 at 12:00 PM

Quote:
Original post by karx11erx
...
I don't think prefixing self-written function names with 'gl' does any harm, as long as I don't use a real OpenGL name.
...

True, it's not too big a deal. It is possible (extremely unlikely however) that there will eventually be a function with the same name added to OpenGL, but the main reason not to prefix your own functions with 'gl' is for code clarity; so that someone else (or maybe even you if you're looking back at your old code for some reason) who is reading your code doesn't get confused.

Quote:
Original post by karx11erx
...
Here's a screenshot: The bright purple texture at the sides should be as dark as the rearward face. If I use GL_MODULATE instead of GL_DECAL for the overlay textures, this works - but then I have cases where the overlay textures gets almost completely merged with the background, instead of clearly standing out.

First let me ask, am I right in assuming that the face in the middle of the screen has just one texture and that's why that one is working fine?

Okay, I think I understand your problem. The problem with what you have now is that the overlay texture isn't being modulated by your pc parameter because you are using GL_DECAL environment mode. When you set it to GL_MODULATE you get the wrong result because it doesn't take into account the overlay texture's alpha channel when it blends. What you want is for the background texture and the overlay texture to both by modulated with the pc color and then blended like in GL_DECAL. ie:

What you have now...     (T<sub>b</sub>C<sub>p</sub>)(1-A<sub>o</sub>) + T<sub>o</sub>A<sub>o</sub>What you want...     (T<sub>b</sub>C<sub>p</sub>)(1-A<sub>o</sub>) + (T<sub>o</sub>C<sub>p</sub>)A<sub>o</sub>

where T_b is the color of the background texture, T_o is the color of the overlay texture, A_o is the alpha of the overlay texture, and C_p is the primary color (glColor4f). Does all that sound right?

If that is what you want, I think you should be able to do this with a little help from texture combiners (became core in OpenGL v1.3, so if you're on Windows you'll have to access it as an extension).

With a little fiddling you can get that function above to be this...

     C<sub>p</sub>(T<sub>b</sub>(1-A<sub>o</sub>) + T<sub>o</sub>A<sub>o</sub>)

which you can see is the primary color modulated by the result of the GL_DECAL function without first modulating the background texture. I'm pretty sure you can do this with texture combiners (it's been a while since I've used them). What you do is set the first texture unit's environment to output just the background texture (GL_REPLACE). Set the second texture unit environment to GL_DECAL so that it outputs what's inside the parentheses above. This is the part I'm not 100% sure about... that you can set up a texture unit environment stage without having a texture bound to that unit. So assuming that's possible, you can set texture unit 2's environment to GL_COMBINE, set the GL_COMBINE_RGB mode to GL_MODULATE, and set the two sources to GL_PRIMARY_COLOR and GL_PREVIOUS.

If you want I can post a little source snippet later (gotta get lunch now) to help out, but I won't be able to test it here at work.

Hope that all helps (and works!)

EDIT: Actually, you definitely shouldn't need to bind a texture to tex unit 2 because the default texture will be bound. You will probably need to enable texturing on that texture unit though.

[Edited by - Kalidor on April 7, 2006 12:00:22 PM]

karx11erx

Apr 10, 2006 at 10:10 AM

Kalidor,

thank you very much for your reply.

Actually, I don't use any functions prefixed 'gl' ... ;)

If you could provide a code snippet I'd appreciate it. I find the OpenGL docs pretty hard to understand.

Kalidor

Apr 10, 2006 at 3:12 PM

Quote:
Original post by karx11erx
Kalidor,

thank you very much for your reply.

Actually, I don't use any functions prefixed 'gl' ... ;)

If you could provide a code snippet I'd appreciate it. I find the OpenGL docs pretty hard to understand.

Yeah, they certainly take some getting used to. [grin]

Here's a little code snippet for you, and remember it's completely untested so it's very likely there's a problem or two (hopefully just syntactic or a typo instead of logical).

//Set up texture unit 0 to output just the background textureglActiveTexture(GL_TEXTURE0);glEnable(GL_TEXTURE_2D);glBindTexture(GL_TEXTURE_2D, backgroundTex);glTexEnvf(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_REPLACE);//Set up texture unit 1 to output the overlay texture blended//with the background texture using the GL_DECAL functionglActiveTexture(GL_TEXTURE1);glEnable(GL_TEXTURE_2D);glBindTexture(GL_TEXTURE_2D, overlayTex);glTexEnvf(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_DECAL);//Now here is the texture combiner part//Set up texture unit 2 to output the background/overlay blend//modulated by the primary colorglActiveTexture(GL_TEXTURE2);glEnable(GL_TEXTURE_2D);//Note we don't bind a texture since we don't use it in the environmentglTexEnvf(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_COMBINE);glTexEnvf(GL_TEXTURE_ENV, GL_COMBINE_RGB, GL_MODULATE);glTexEnvf(GL_TEXTURE_ENV, GL_SOURCE0_RGB, GL_PRIMARY_COLOR);glTexEnvf(GL_TEXTURE_ENV, GL_OPERAND0_RGB, GL_SRC_COLOR);glTexEnvf(GL_TEXTURE_ENV, GL_SOURCE1_RGB, GL_PREVIOUS);glTexEnvf(GL_TEXTURE_ENV, GL_OPERAND1_RGB, GL_SRC_COLOR);//What that does is set texture unit 2's environment to the modulate//combine function (arg0 * arg1) and sets arg0 to the primary color//and arg1 to the result from the previous texture combiner stage//Now you render your geometry//Remember to disable texturing on all the texture units so we don't//accidently mess up something else we try to do after thisglActiveTexture(GL_TEXTURE2);glDisable(GL_TEXTURE_2D);glActiveTexture(GL_TEXTURE1);glDisable(GL_TEXTURE_2D);glActiveTexture(GL_TEXTURE0);glDisable(GL_TEXTURE_2D);

Hope that works for you. If there are any problems you can't figure out just post back and I'll try to look into it more.

karx11erx

Apr 10, 2006 at 5:47 PM

Thank you very much indeed. I wonder how long it would have taken me to figure that by reading OpenGL docs and tutorials. Probably forever. :)

karx11erx

Apr 11, 2006 at 6:43 PM

Kalidor,

it doesn't work ... :(

[Edited by - karx11erx on April 12, 2006 3:43:11 PM]

Kalidor

Apr 13, 2006 at 10:42 AM

Quote:
Original post by karx11erx
Kalidor,

it doesn't work ... :(

Sorry for the late reply.

Hmm, I'm not sure what the problem might be. Could you explain exactly how it isn't working and maybe post another screenshot? Are you getting any OpenGL errors (you added in the error checking now, right? [grin])? If this method really just won't work I think it would be easiest to just create textures with the background and overlay blended already (I'm still assuming that's what you do for the face that works correctly) and then just use GL_MODULATE texture environment.

You could do any custom texture blending you want if you used fragment shaders, but it looks like that's not a requirement you want for this game.

karx11erx

Apr 13, 2006 at 3:14 PM

There are no errors when using your code, and it looks like the image I have posted above.

I am using pixel shaders for certain cases (color key transparency), but they cut the frame rate in half - which amazes me. Just blending two textures using shaders halves the frame rate? D'oh. Well, I am not a Cg expert (I wish I was), and I didn't write the shaders. A guy who built lightmaps into this program created them, because he failed to make them work with multitexturing, for obvious reasons ...

Currently, I am rendering overlay textures in a separate render call. It's pretty costly to create blended textures with 512x512x32 textures.

[Edited by - karx11erx on April 14, 2006 6:14:17 AM]

Kalidor

Apr 14, 2006 at 6:11 PM

Quote:
Original post by karx11erx
There are no errors when using your code, and it looks like the image I have posted above.

I am using pixel shaders for certain cases (color key transparency), but they cut the frame rate in half - which amazes me. Just blending two textures using shaders halves the frame rate? D'oh. Well, I am not a Cg expert (I wish I was), and I didn't write the shaders. A guy who built lightmaps into this program created them, because he failed to make them work with multitexturing, for obvious reasons ...

Currently, I am rendering overlay textures in a separate render call. It's pretty costly to create blended textures with 512x512x32 textures.

Hmm, I really don't know why that's not working, sorry.[depressed] Maybe someone who can tell what's wrong with my idea/code will jump in.

Since shaders are already a requirement for you, you might as well make one for this as well. Just using shaders shouldn't decrease framerate that much at all, unless the shader is extremely complicated which color key transparency shouldn't be. The only thing I could think of right now that might be slowing it down that much is that you are binding/unbinding that shader a lot during the frame. Binding a shader is the most expensive state change there is so it is best to keep them to a minimum.

There's a lot of good info out there on how to get started with shader programming so do a google search for that.

Sorry I couldn't be of more help.

Topic Locked

This topic has been locked by a moderator. New replies are not allowed.