🔒 Locked

STL String madness

Started by AndyGeers Apr 15, 2006 at 2:58 PM 4 replies 1.2k views

Original Post

Apr 15, 2006 at 2:58 PM

I am totally at my wits' end here, pulling my hair out and so on, getting some totally bizarre behaviour... I have a class like so:


#include <string>

class CXTemplate
{
private:
std::string m_strName;

public:
CXTemplate(const std::string& strName) : m_strName(strName) { }
const std::string& GetName() const { return m_strName; }
}

But when I try to use it:


CXTemplate* t = new CXTemplate("Frame");
CLog::Get()->Log(t->GetName().c_str());

... it just logs the word "(null)" and I get all sorts of crashes and stuff if I try to use it. I just don't get it!

RDragon1

206

RDragon1

Apr 15, 2006 at 4:40 PM

I would really return that string by value, not reference.

MaulingMonkey

249

MaulingMonkey

Apr 15, 2006 at 5:00 PM

Quote:
Original post by RDragon1
I would really return that string by value, not reference.

Any particular reason? It's not returning a stack-local variable or anything...

OP: Nothing visibly wrong with the code posted. Chances are your string is getting clobbered by buffer overflows or the like elsewhere in the program, or your Log function is broken. Suggest stepping through with a debugger?

leiavoia

129

leiavoia

Apr 15, 2006 at 5:04 PM

What does "std::cout << t->GetName()" produce?

Obviously, if it's something valid, the problem is in your logger.

rip-off

Mod

445

rip-off

Apr 15, 2006 at 5:20 PM

Quote:
Original post by leiavoia
What does "std::cout << t->GetName()" produce?

Obviously, if it's something valid, the problem is in your logger.

I tried his code with cout earlier on before the server stopped talking to me { =( } and it worked.

As MaulingMonkey suggested, the problem is probably with your logger.

It could also be that your actual code is more complicated than that and you are doing something else wrong.

AndyGeers

Author

AndyGeers

Apr 17, 2006 at 3:26 PM

Thanks for taking the time to help, people.

As predicted, it was some other problem. The full definition of the CXTemplate class was like this:

class CGraphics;class CXTemplate{public:	typedef bool (CGraphics::*TEMP_HANDLER)(CMesh* pMesh, CXFileObject*);private:	TEMP_HANDLER m_pHandler;								std::string m_strName;...}

... and it seems that once the full definition of CGraphics got pulled in the code that used CXTemplate, it affected the memory layout. It's a minor shame to have to introduce a dependency on Graphics.h into all files that use XTemplate.h, but not the end of the world - at least it works now!

Topic Locked

This topic has been locked by a moderator. New replies are not allowed.