shared_ptr conversion problem

mods.push_back(shared_ptr(libs[0].GetModuleP(log, &inq, &outq, SW, SH, params0)));

Does this work?

mods.push_back(shared_ptr<Module>(libs[0].GetModuleP(log, &inq, &outq, SW, SH, params0)));

Thanks.

Would it make sense to make GetModule() return a shared_ptr rather than the raw pointer ? You run the risk that somewhere else in the code, the raw pointer will again be assigned to a shared_ptr which creates an instant bug. The issue is that you create two systems with responsibility for memory management, rather than one underlying reference count that gets transmitted between shared_ptr copies and assignments. If GetModule can potentially be called more than once while returning the same pointer value there will be a problem.

By example,

struct A{       A() { std::cout << "constructor" << std::endl; }    ~A() { std::cout << "destructor" << std::endl; }};int main(){       using boost::shared_ptr;    shared_ptr< A> a, b;    A *p = new A;    a = shared_ptr< A>( p);    b = shared_ptr< A>( p);}

In this case A's constructor is called once, but the destructor is called twice which is obviously bad form.