C++ Code errors Constructors

because your not assigning them the values passed to the constructor..
in order for the members of your class to actually have values you have to do something like this



otherwise the members will be considered uninitialised and thus containing 'gibberish' values such as you are getting.
usually the 'this->' wouldnt be placed there but because you have given the parameters of the constructor the same names as the members (variables of a class) it has to be.

Try not to do things like 'wspd' instead type out its full name like WalkSpeed, walkSpeed, walk_speed or m_WalkSpeed ( m is for member ) and so on. The reason for that is, it 'self comments' your code which means there is no need for the a comment at the side of each variable and is easier to understand throughout the rest of your code. Also why does your class name start with a g? g usually stands for global and that class isnt a global its a 'type' or 'blueprint' for a variable ( an instance of the class commonly called an object ).

Hope that was understood
~CC

Thanks, Ill try that...

Also, im used to the short words, I think they are easy to remember, but it varies...
Also, the 'g' in front of the class is because its not the whole thing... it means ground monster, and this is just a sketch anyway, so it doesnt matter..

hehe, ok thanks, it worked now. ill keep this in mind :D
as I said, im still inexperienced in c++ and programming in general, so its very good when you people help me out ^^

Quote:

Original post by Ov3 hehe, ok thanks, it worked now. ill keep this in mind :D as I said, im still inexperienced in c++ and programming in general, so its very good when you people help me out ^^

Thats not a problem dude, everyone has to start somewhere, and im pretty positive i made some silly mistakes when i first started out also [smile].
However i still think you should stop abbreviating the names of your variables and types unless your using the Hungarian Notation nameing convention.

But its up to you in the end i guess.

Yeah, I probably should XD

im changing it now, and ill try to remember x)

Quote:

Original post by Ov3 Hi, im kinda new to C++, I just read some guides and books...

As your in the learning stage I think there is some benefit to me pointing out some good practices for modern C++ coding:

1) Don't apply using namespace std; in a header file (I assume that's what this is), because it'll ripple down to other files and pollute the namespace, better to use fully qualified names instead, e.g. std::cout

2) Descriptive names are favoured by most people really, like GroundEnemy rather than gEnemy and attackSpeed over aspd.

3) Don't use char arrays/C-style strings and string manipulation functions, use the modern C++ equivalent: std::string name;

4) Constructors need to initialise the variables otherwise, as you've found, they contain nonsense values. To construct member variables directly from the constructor's parameters you can use an initialisation list:

Using initialiser lists like is the preferred way rather than assigning variables individually like CodeCriminal's suggestion.

5) Rather than a showInfo function you can overload the output stream operator:



6) Don't use system("PAUSE") because it's non-portable and completely overkill to ask the operating system to pause your program and wait for a key. Instead just wait for a single character to appear on the input stream with this: std::cin.get(); You could print out a "Press Any Key" message beforehand too if you wanted.

7) The return 0 is actually optional, the compiler will add it for you if you omit it, so unless you plan on returning anything other than zero then you might as well save yourself a line or two and get rid.