Skip to main content
gamedev.net
🔒 Locked

[java] Java Keyboard/Mouse input "serialization" issue

Started by japro Sep 21, 2011 at 3:59 PM 1 replies 1.4k views
Original Post
japro
japro
So wrote this little applet:
http://progsch.net/applets/proto.html

The problem is that the controls seem to be entierly broken on Macs, and sometimes they also behave weirdly on my Linux boxes. What happens often on linux is that keys seem to get stuck and only get "unstuck" if they are tapped again (i get the same thing in minecraft btw.). Also very rarely the mouse dragging stops working entirely. Mac users generally report it to not respond to any controls at all. I somehow once got it to respond on my mothers macbook by pretty much just randomly pressing keys/changing focus/clicking around, but I have no idea what triggered it.

I use the following input serializer class:
[source lang="java"]
package net.progsch;

import java.awt.Point;
import java.awt.event.InputEvent;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
import java.awt.event.MouseMotionListener;
import java.util.ArrayDeque;
import java.util.Queue;

public class InputSerializer implements KeyListener, MouseListener, MouseMotionListener {
private boolean [] keys = new boolean[65536];
private Point mousePos = new Point();
private Queue events = new ArrayDeque();

public InputSerializer() {
for(int i = 0;i<65536;++i)
keys = false;
}

public InputEvent poll() {
return events.poll();
}

public Point getMousePosition() {
return mousePos;
}

public boolean isKeyDown(int code)
{
return keys;
}

@Override
public void keyPressed(KeyEvent arg0) {
events.add(arg0);
keys[arg0.getKeyCode()] = true;
}

@Override
public void keyReleased(KeyEvent arg0) {
events.add(arg0);
keys[arg0.getKeyCode()] = false;
}

@Override
public void keyTyped(KeyEvent arg0) {
events.add(arg0);
}

@Override
public void mouseDragged(MouseEvent arg0) {
events.add(arg0);
}

@Override
public void mouseMoved(MouseEvent arg0) {
events.add(arg0);
mousePos = arg0.getPoint();
}

@Override
public void mouseClicked(MouseEvent arg0) {
events.add(arg0);
}

@Override
public void mouseEntered(MouseEvent arg0) {
events.add(arg0);
}

@Override
public void mouseExited(MouseEvent arg0) {
events.add(arg0);
}

@Override
public void mousePressed(MouseEvent arg0) {
events.add(arg0);
}

@Override
public void mouseReleased(MouseEvent arg0) {
events.add(arg0);
}
}
[/source]

And the part processing the events looks like:
[source lang="java"]
private void step() {

if(input.isKeyDown(KeyEvent.VK_A))
alpha += 0.02;
if(input.isKeyDown(KeyEvent.VK_D))
alpha -= 0.02;
if(input.isKeyDown(KeyEvent.VK_W) && beta<0)
beta += 0.02;
if(input.isKeyDown(KeyEvent.VK_S) && beta > -Math.PI/2)
beta = Math.max(beta-0.02, 0.0001-Math.PI/2);

InputEvent e;
while((e = input.poll())!=null)
{
if(e instanceof KeyEvent)
{
KeyEvent ke = (KeyEvent) e;
if(ke.getKeyCode() == KeyEvent.VK_SPACE && ke.getID() == KeyEvent.KEY_PRESSED)
{
map.setSeed((int)(Math.random()*1000000));
map.generate();
}
}
else if(e instanceof MouseEvent)
{
MouseEvent me = (MouseEvent) e;
if(me.getID() == MouseEvent.MOUSE_PRESSED && (me.getModifiersEx() & MouseEvent.BUTTON3_DOWN_MASK)!=0)
{
mouseDownPos = me.getPoint();
}
if(me.getID() == MouseEvent.MOUSE_DRAGGED && (me.getModifiersEx() & MouseEvent.BUTTON3_DOWN_MASK)!=0 && Math.cos(beta)>0.001)
{
offx -= Math.cos(alpha)*(double)(me.getX()-mouseDownPos.x)/SCALE - Math.sin(alpha)/Math.cos(beta)*(double)(me.getY()-mouseDownPos.y)/SCALE;
offy -= Math.sin(alpha)*(double)(me.getX()-mouseDownPos.x)/SCALE + Math.cos(alpha)/Math.cos(beta)*(double)(me.getY()-mouseDownPos.y)/SCALE;
mouseDownPos = me.getPoint();
}
}
}
}[/source]

I'm at a loss since googling for "java input problem" or similar is way too unspecific <img alt=":D" class="bbc_emoticon" src="http://public.gamedev.net/public/style_emoticons/<#EMO_DIR#>/biggrin.gif"/>
Angex
Angex
I'm guessing that the "step()" method doesn't run from the AWT Event Dispatch thread, so it looks like a synchronization problem.

Just considering the "keys" array, try something like this:

[source lang="java"]

public boolean isKeyDown(int code) {
synchronized(this) {
return keys;
}
}

@Override
public void keyPressed(KeyEvent arg0) {
events.add(arg0);

synchronized(this) {
keys[arg0.getKeyCode()] = true;
}
}

@Override
public void keyReleased(KeyEvent arg0) {
events.add(arg0);

synchronized(this) {
keys[arg0.getKeyCode()] = false;
}
}
[/source]

Also with regards to focus, just check which component you adding the listeners too. Is it the JFrame or some other container?
That component will need focus in order to dispatch any events.
Paul65
Paul65
My guess is that your InputSerializer class is losing focus. Only the actual class with input focus will receive keyboard messages. Add a focus listener to it to see if this is happening.

Topic Locked

This topic has been locked by a moderator. New replies are not allowed.

Sign in to reply to this topic.