Class confusion?

Have you read this article?

Have you read this article?

I have but im still confused as to why this isnt working?

You are accessing class instance variables as if they were class static variables. One solution is to declare your global objects as "extern", an outline of which is presented in the article I linked. Another is to not use globals, but instead pass pointers or references to the necessary objects.

Yet another solution is to decouple the classes. The Car class shouldn't need to worry about the Menu. Instead, invert the logic: only update the car when the menu isn't in the way. You could split the renderer into a menu renderer, and an in-game renderer.

Aside: don't declare functions you didn't write. Include the Windows header, do not copy the signature for GetAsyncKeyState(). I would recommend using an enumeration rather than cryptic magic numbers for your Menu states. The player/car position should certainly not be "static". I would recommend such long Sleep() durations in an interactive application. If you want an action to be delayed, use an explicit timer instead.

You are accessing class instance variables as if they were class static variables. One solution is to declare your global objects as "extern", an outline of which is presented in the article I linked. Another is to not use globals, but instead pass pointers or references to the necessary objects.

Yet another solution is to decouple the classes. The Car class shouldn't need to worry about the Menu. Instead, invert the logic: only update the car when the menu isn't in the way. You could split the renderer into a menu renderer, and an in-game renderer.

Aside: don't declare functions you didn't write. Include the Windows header, do not copy the signature for GetAsyncKeyState(). I would recommend using an enumeration rather than cryptic magic numbers for your Menu states. The player/car position should certainly not be "static". I would recommend such long Sleep() durations in an interactive application. If you want an action to be delayed, use an explicit timer instead.

Thank you for this , i got it working after including the extern carclass.car
Been working on getting rotation to work and camera following for quite sometime.
I didn't want to use sleep() but since at this moment of time my keyinput isnt properly done , im having to use sleep otherwise my changing states number goes way to fast(causing it to go through the menu way to fast).
In c# i used a keypress as opposed to keydown in things such as the menu.

In c# i used a keypress as opposed to keydown in things such as the menu.
[/quote]
You can implement key press/release detecting on top of GetASyncState(). You simply have a flag of the previous state, and if the current state is different from the previous state, there has been a transition. You could also detect key presses in your window procedure.

This is why Sleep() is poor, if you implement state flags above, your internal view of the state of the keyboard could get out of sync with the actual state, because you have not been polling fast enough.

I didn't want to use sleep() but since at this moment of time my keyinput isnt properly done , im having to use sleep otherwise my changing states number goes way to fast(causing it to go through the menu way to fast).
[/quote]
You can prevent this by having an internal timer that tells you when to move the cursor. Every time you detect that the key is pressed, move the cursor one space and then set a "reminder" to move it again in +N milliseconds.

E.g:

class Menu
{
enum Button {
NewGame,
Settings,
Exit,
};

static const int TotalButtons = Exit + 1;

static const int CursorTimeoutMs = 2000;

public:

void update(Input &input, Timer &timer)
{
int currentTime = timer.currentMilliseconds();

if(input.keyDown(Input::VK_DOWN))
{
if(direction != 1)
{
direction = 1;
timer = currentTime - CursorTimeoutMs;
}
}
else if(input.keyDown(Input::VK_UP))
{
if(direction != -1)
{
direction = -1;
timer = currentTime - CursorTimeoutMs;
}
}
else
{
direction = 0;
}

if(direction != 0 && currentTime >= timer + CursorTimeoutMs)
{
if(current > 0 && current < TotalButtons)
{
current += direction;
}
timer = currentTime;
}
}

private:
Button current;
int direction;
int timer;
};

I haven't tested that, but something like that should work. In the code above, I actually avoid having two code paths that update the cursor by setting a reminder "in the past".