🔒 Locked

for (score and seven; years_ago; ...

Started by Cornstalks Sep 24, 2013 at 11:28 PM 8 replies 3.9k views

Original Post

Sep 24, 2013 at 11:28 PM

My coworker just showed me this piece of beauty he wrote in a project for a client. It's gloriously horrible. And hilarious.


#define years_ago (score < 4)
#define and =
#define our_forefathers (score++)
#define seven 0
int score;
 
- (void)setImage:(UIImage *)image
{
    ...
    for (score and seven; years_ago; our_forefathers) {
        GPUImagePicture * stupidlyNamedClassFromALibraryWithNoRegardForDevelopers = [[GPUImagePicture alloc] initWithImage:image];
        ...
    }
}

frob

Sep 24, 2013 at 11:48 PM

... he wrote in a project for a client ...

#define years_ago (score < 4)
#define and =
#define our_forefathers (score++)
#define seven 0

And when they do a code review, he might discover they are a FORMER client.

It might look cute, but in a professional environment stunts like that can easily mean losing your job.

Cornstalks

Sep 25, 2013 at 12:13 AM

And when they do a code review, he might discover they are a FORMER client.

It might look cute, but in a professional environment stunts like that can easily mean losing your job.

The client is actually a programmer himself and did a code review, and inserted the comments:


...
// my favorite #define ever.
#define seven 0
int score;
 
- (void)setImage:(UIImage *)image
{
    ...
    // Friggin awesome.
    for (score and seven; years_ago; our_forefathers) {
        ...
    }
}

So I guess it's all good.

frob

Sep 25, 2013 at 2:02 AM

Very lucky for him it didn't turn out different.

Sik_the_hedgehog

Sep 25, 2013 at 3:01 AM

Bonus: and is actually a keyword in C++ (inherited from iso646.h then made part of the language), so that macro is effectively changing the language itself. Can't get worse than this.

Reminds me of somebody who found long long ago in a file, except of course in that case it was something perfectly acceptable that happened to fit perfectly (long long is a built-in type, and ago is a variable name). No cheating needed there.

Veiled Glitch

Sep 29, 2013 at 1:42 PM

I, I don't even know what to say...

stupid_programmer

Sep 29, 2013 at 7:12 PM

Bonus: and is actually a keyword in C++ (inherited from iso646.h then made part of the language), so that macro is effectively changing the language itself. Can't get worse than this.

Reminds me of somebody who found long long ago in a file, except of course in that case it was something perfectly acceptable that happened to fit perfectly (long long is a built-in type, and ago is a variable name). No cheating needed there.

The code is Objective-C so no worries about it being a keyword. But it is Objective-C which is a coding horror of its own. I shudder the days I need to work on iOS stuff at work.