Error is driving me nuts

Oh noes, my code is teh crash!

I would note that in a few places you're using assignment rather than an equality check:

if (a = b) {
   // ....
}

Code that looks like the above sets a to b's value, then tests whether a's value is false.

So this code:

if (gameState = Exiting) {
    return true;
}

gameState will be set to "Exiting". Exiting is non-zero so the return statement would then be executed.

Have you tried a debug build? Debugging should give you a more detailed error message.

Are you sure the error occurs in this file? You're missing a main() so I'm guessing you have more code.

Also, your if conditions in Game::Exit() and Game::GameLoop() don't do what you think they do. You're setting game State instead of testing it.

changed it to

bool Game::Exit(){
	if(gameState == Game::Exiting){
		return true;}
	else{return false;};
};

still have the same problem

ps, i'm using http://www.gamefromscratch.com/page/Game-From-Scratch-CPP-Edition-Part-2.aspx as an example

could the problem come from the basic.h :

#include <SFML\Graphics.hpp>
#include <SFML\Audio.hpp>
#include <SFML\Window.hpp>
#include <SFML\System.hpp>

#include <iostream>
#include <ctime>
#include <map>
#include <cmath>
#include <cstdlib>
#include <cassert>

Have you tried running the code in a debugger yet?

1. Read through the information in the link rip-off provided.

2. Determine which line of code causes the error, or, at a minimum, in which group of 3 or 4 lines of code the error occurs.

In general, when you encounter an error, go through your code once or twice looking for obvious typos or logic errors. If that doesn't resolve the problem, debug your code by setting breakpoints, examining values, determining which routines work correctly, etc.

EDIT: As mentioned several times above, running your code in a good debugging IDE will likely result in the debugger indicating which line the error occurs.

can you give me a link to a good debugger?

Many IDE's have one built in. If you're using Visual Studio, you already have one. Put your cursor at line 6 and hit F9 to set a break point. Then run your code and it should show you line by line what is happening. Hit F10 to execute that line and go to the next line or F11 to call into that line and go deeper into the call stack (like into a function). Use the Locals or Watch Window to inspect variables.

If you aren't using Visual Studio, I recommend Googling MyDevelopmentTool Debugger and figure out how to do it there.

Usually an error like that means you're assigning something to a null pointer and the debugger will show you exactly where the problem is.

- Eck

found the problem:

Game::GameState Game::gameState = Uninitialized;
sf::RenderWindow Game::MainWindow;

i'm currently looking into it

screw it, going to try a different guide

Ok, just remember you're going to run into this kind of problem eventually, and you'll need to learn how to fix it. It is an important part of learning C++.

Can you describe what you mean by "found the problem"? Do you have a stack trace of the crash?

I was able to get the guide you posted to work on Linux, but it is a little different from the code you posted (i.e. there is no "Basic.h"). Can you get the exact code in the guide to compile and run successfully?

I think that there is a problem with

Game::GameState Game::gameState = Uninitialized;

because that's where it stops when the error appears but i don't know why, if somebody can help me, please do because I can't get it out of my head

Can you post what information the debugger gives you when it stops there? It should give you a stack trace and a detailed message of why it stopped there.

I don't know if this helps but when started pong again this appeared:

currently trying something but don't know if it will work so if you know something, please tell me

I know that there is something wrong with Game::GameState Game::gameState = Uninitialized; because that's when the error appears and i get this in the output:

I know that there is something wrong with Game::GameState Game::gameState = Uninitialized; because that's when the error appears and i get this in the output:
First-chance exception at 0x77cad062 in pong.exe: 0xC0000005: Access violation writing location 0x00000004.
Unhandled exception at 0x77cad062 in pong.exe: 0xC0000005: Access violation writing location 0x00000004.

That specific error is that you are following a null pointer, and writing data to it.

On modern operating systems the range from 0x00000000 up through a fairly high number are all reserved. NULL on these operating systems is also memory address zero, so you doing a little math, since many variables are at a 4-byte step, you are almost certainly setting the second variable of a structure or class where the pointer is null. For example, the line might be myPtr->foo = value; where myPtr is 0 instead of a valid pointer.

Your debugger should tell you the line of code that corresponds to the code address 0x77cad062. If your debugger doesn't tell you for some reason, those useful little debugging files the compiler generates, such as map files, can tell you as well.

I kind of guessed this was the case, but i don't understand why it is a null pointer or how to fix it.

I also don't understand how the line of code being referenced is the root cause of that error.

Are you sure you're looking at the correct file? Sometimes it is possible to end up with multiple copies of a file, one of which you're editing and another which ends up being compiled. Are you sure the executable you're running is up to date? Some IDEs make it easy to run the old executable when building a new one fails.

Have you tried a simpler program, such as placing all the code in a single file, something like:

#include <SFML/System.hpp>
#include <SFML/Window.hpp>
#include <SFML/Graphics.hpp>
 
#include <iostream>
#include <ctime>
#include <map>
#include <cmath>
#include <cstdlib>
#include <cassert>
 
enum GameState {
    Playing,
    Exiting
};
 
int main() {
    sf::RenderWindow MainWindow;
    MainWindow.create(sf::VideoMode(1024, 768, 32), "Pong");
    GameState gameState = Playing;
    while (gameState != Exiting) {
        sf::Event Event;
        while (MainWindow.pollEvent(Event)) {
            if ( (Event.type == sf::Event::Closed) || (sf::Keyboard::isKeyPressed(sf::Keyboard::Escape)) ) {
                gameState = Exiting;
            }
        }
        MainWindow.clear(sf::Color::Black);
        MainWindow.display();
    }
}