delete [] problem

// pBuff now equals (for example) 1000 BYTE *pBuff = new BYTE[dwWidth * dwHeight]; while(!m_pRAW.eof()) { // pBuff now equals pBuff+1, 1001, 1002, 1003 m_pRAW >> *pBuff++; } // Oh, look! We''re deleting 1000+x NOT 1000! That''s the problem. delete [] pBuff; m_pRAW.close();

Use increments wisely.

[Resist Windows XP''s Invasive Production Activation Technology!]

Isn''t that when you use the new operator, the assignment would point the pointer at the first element in the array?

What do I have to do? I''ve tried allocating an extra byte for the forward referencing in the buffer. Still no good

==============
BYTE* pBuff = new BYTE[dwWidth + dwHeight + 1];
for (INT i = 0; i < dwHeight; i++)
for (INT j = 0; j < dwWidth; j++)
m_pRAW >> *pBuff++;
==============
I even made the changes above but still the error would still come out.

You can treat pBuff just like an array (pBuff[0], etc.). Just use a counter to get the index location.

Or, using that counter again, I think you could use *(pBuff + counter). That SHOULD do the same thing (I'm full of shoulds).

Edited by - Dragonskin on December 3, 2001 8:31:23 PM

Don''t make is so complex.

BYTE *pBuff = new BYTE[dwWidth * dwHeight]; BYTE *Inc = pBuff; while(!m_pRAW.eof()) { m_pRAW >> *Inc++; } delete [] pBuff; m_pRAW.close();

[Resist Windows XP''s Invasive Production Activation Technology!]

Dragonskin :

Did that and another error came out. Here''s the modified code as you suggested.

m_pRAW >> *(pBuff + i * j);

Null :

Tried your suggestion and still the same error came out.

quote:

---

Original post by synthexp
Tried your suggestion and still the same error came out.

---

Well, then:
1) You have more errors than the obvious one I pointed out. You could be overrunning your buffer. You are using an unsafe input method, so that''s a possibility.
2) You wrote something incorrectly.

[Resist Windows XP''s Invasive Production Activation Technology!]

An update
------------------------------
BYTE* pBuff = new BYTE[dwWidth * dwHeight];

for (INT i = 0; i < dwHeight; i++)
for (INT j = 0; j < dwWidth; j++)
m_pRAW >> *(pBuff + i * j);

// Convert the image
//ConvertImage (pBuff, dwWidth, dwHeight);
SendMessage (GetDlgItem (GetHDLG (), IDC_PRGCURRENT), PBM_STEPIT, 0, 0);

// Close/delete all objects
delete [] pBuff;

------------------------------
Well, I tried assigning only one byte to pBuff and was hoping that the loop would die after j reaches 1 but it turned that it did not. Because I assigned only one byte to pBuff and the memory space is good only for one byte or when j == 1, next assignment to pBuff would generate exception. Now I''m at loss on why it did not happen. Can anybody care to explain?

One more thing, how do I read the whole file and dump the whole of them into pBuff without going through the loop. If someone have any idea on how to read a RAW file using ifstream, I''ll be happy if someone would care to share it. Thanks.

Isn''t there something like ''file.read(buffer,size)''? I don''t use the C++ i/o library much. With the C library it uses ''fread(buffer,size,count,file)'', but that''s not very useful to you .

[Resist Windows XP''s Invasive Production Activation Technology!]

for (INT i = 0; i < dwHeight; i++) for (INT j = 0; j < dwWidth; j++) m_pRAW >> *(pBuff + i * j);

Should probably be:

for (INT i = 0; i < dwHeight; i++) for (INT j = 0; j < dwWidth; j++) m_pRAW >> *(pBuff + (i * dwWidth + j)); // <-- change

But why not replace it with:

m_pRAW.read(pBuf, dwHeight * dwWidth * sizeof BYTE);

Thanks Brother Bob,

The last suggestion worked. Instead of byte per byte copying, the whole file content is dumped to the buffer. Again, many thanks to all of you too.