Size of binary file? [C++]

[quote name='MatsK' timestamp='1298841537' post='4779842']
Nevermind, I figured it out!
Thanks guys!

Part of the idea here on gamedev is sharing solutions to problems. So, what was the problem and what was the fix (in case someone else runs into a similar problem)?
[/quote]

The problem was that the filename was wrong. When I tried to print it out to the console, it only displayed part of the filename. That probably had something to do with the way I was doing it though.
The thing is, my program converts files from *.bmp to *.png, and I had already deleted all my extracted *.bmp files when this particular piece of code was being run, so the filename was not found.
I ended up converting the char* to a std::string and replacing 'bmp' with 'png'.

 char* Filename = new char[m_Entries.FilenameLength];
 memcpy(Filename, &m_Entries.Filename, m_Entries.FilenameLength);
 string StrFilename(Filename, Filename + m_Entries.FilenameLength);
 StrFilename = Replace(StrFilename, "bmp", "png");
 
 ifstream CurrentFile(StrFilename.c_str(), ios::in | ios::binary | ios::ate);
 //CurrentFile.seekg(0, ios::end);
 ifstream::pos_type size = CurrentFile.tellg();

 string Replace(string Str, string From, string To)
 {
 int Position = Str.find(From);
 
 while(Position != string::npos)
 {
 Str = Str.replace(Position, From.length(), To);
 Position = Str.find(From, Position + From.length());
 }
 
 return Str;
 }

I had already written the Replace() function before I ran into this problem.
Now that I think about it, I should probably replace 'bmp' with '.bmp' and 'png' with '.png' in order to minimize the chance that a random character sequence that is actually part of the filename itself is replaced.

Here is the full sourcecode for the class I'm working on:

#include "stdafx.h"
 #include "FileArchive.h"
 #include <assert.h>
 #include <iostream>
 #include "Compress.h"
 #include "FreeImage.h"
 
 namespace Archives
 {
 string Replace(string Str, string From, string To);
 
 FileArchive::FileArchive(string Path)
 {
 char Signature[8];
 char Version[4];
 char ManifestOffset[4];
 char NumFiles[4];
 
 m_ArchivePath = Path;
 
 ifstream Archive(Path.c_str(), ios::in | ios::binary);
 Archive.read(Signature, sizeof(FARSignature));
 
 string StrSignature(Signature, Signature + 8);
 
 assert(StrSignature == "FAR!byAZ");
 cout << "Signature: " << StrSignature << "\r\n";
 
 Archive.read(Version, 4);
 m_Version = *((int*)Version);
 
 assert(m_Version == 1 || 3);
 
 Archive.read(ManifestOffset, 4);
 m_ManifestOffset = *((unsigned int*)ManifestOffset);
 
 Archive.seekg(m_ManifestOffset, ios::beg);
 
 Archive.read(NumFiles, 4);
 m_NumFiles = *((unsigned int*)NumFiles);
 
 Archive.close();
 }
 
 void FileArchive::Process()
 {
 ifstream Archive(m_ArchivePath.c_str(), ios::in | ios::binary);
 
 char DecompressedDataSize[4];
 char CompressedDataSize[3];
 char DataType[1];
 char DataOffset[4];
 char Compressed[1];
 char AccessNumber[1];
 char FilenameLength[2];
 char TypeID[4];
 char FileID[4];
 char* Filename;
 
 //Seek past the number of files...
 Archive.seekg(m_ManifestOffset + 4, ios::beg);
 
 for(unsigned int i = 0; i < m_NumFiles; i++)
 {
 FAR3Entry Entry;
 
 Archive.read(DecompressedDataSize, sizeof(unsigned int));
 Entry.DecompressedDataSize = *((unsigned int*)DecompressedDataSize);
 
 Archive.read(CompressedDataSize, 3);
 Entry.CompressedDataSize = *((unsigned int*)CompressedDataSize);
 
 Archive.read(DataType, sizeof(unsigned char));
 Entry.DataType = *((unsigned char*)DataType);
 
 Archive.read(DataOffset, sizeof(unsigned int));
 Entry.DataOffset = *((unsigned int*)DataOffset);
 
 Archive.read(Compressed, sizeof(unsigned char));
 Entry.Compressed = *((unsigned char*)Compressed);
 
 Archive.read(AccessNumber, sizeof(unsigned char));
 Entry.AccessNumber = *((unsigned char*)AccessNumber);
 
 Archive.read(FilenameLength, sizeof(unsigned short));
 Entry.FilenameLength = *((unsigned short*)FilenameLength);
 
 Archive.read(TypeID, sizeof(unsigned int));
 Entry.TypeID = *((unsigned int*)TypeID);
 
 Archive.read(FileID, sizeof(unsigned int));
 Entry.FileID = *((unsigned int*)FileID);
 
 Filename = new char[Entry.FilenameLength];
 Archive.read(Filename, Entry.FilenameLength);
 memcpy(&Entry.Filename, Filename, Entry.FilenameLength);
 
 string StrFilename(Filename, Filename + Entry.FilenameLength);
 cout << "Filename: " << StrFilename << "\r\n";
 
 m_Entries.push_back(Entry);
 
 char* Buffer = new char[Entry.DecompressedDataSize];
 
 //Don't convert tgas...
 if(StrFilename.find(".tga") == string::npos)
 {
 FARExtractItemFromFileByName(m_ArchivePath.c_str(), StrFilename.c_str(), 
 (unsigned char**)&Buffer, 1);
 
 FREE_IMAGE_FORMAT Fif = FreeImage_GetFIFFromFilename(StrFilename.c_str());
 
 if(Fif != FIF_UNKNOWN)
 {
 FIBITMAP *Img = FreeImage_Load(Fif, StrFilename.c_str());
 FreeImage_Save(FREE_IMAGE_FORMAT::FIF_PNG, Img, Replace(StrFilename, ".bmp", ".png").c_str());
 
 remove(StrFilename.c_str());
 //delete Img; //This causes an assertion... o_O
 }
 }
 
 delete Buffer;
 }
 
 RecreateArchive();
 }
 
 void FileArchive::RecreateArchive()
 {
 int ManifestOffset = 11;
 
 ofstream Archive(Replace(m_ArchivePath, ".dat", ".tmp").c_str());
 Archive << "FAR!byAZ"; //Signature
 Archive << 3; //Version
 Archive << 0x00; //ManifestOffset
 
 for(unsigned int i = 0; i < m_NumFiles; i++)
 {
 char* Filename = new char[m_Entries.FilenameLength];
 memcpy(Filename, &m_Entries.Filename, m_Entries.FilenameLength);
 string StrFilename(Filename, Filename + m_Entries.FilenameLength);
 StrFilename = Replace(StrFilename, ".bmp", ".png");
 
 ifstream CurrentFile(StrFilename.c_str(), ios::in | ios::binary | ios::ate);
 //CurrentFile.seekg(0, ios::end);
 ifstream::pos_type size = CurrentFile.tellg();
 
 unsigned char *MemBlock = new unsigned char[size];
 CurrentFile.seekg(0, ios::beg);
 CurrentFile.read((char*)MemBlock, size);
 
 unsigned char* Dst = mynew<unsigned char>((int)size - 1);
 unsigned char* DstEnd = compress((unsigned char*)MemBlock, (unsigned char*)MemBlock + size, 
 Dst, Dst + size - 1, false);
 
 cout << "Bob the builder, can he compress it? \r\n"; 
 
 //Write the compressed...
 if(DstEnd)
 {
 unsigned int DstLength = DstEnd - Dst;
 
 //TODO: Write FAR3 Compression header.
 cout << "Yes he can!\r\n\r\n";
 
 //Update the offset for the location of the data!
 m_Entries.DataOffset = Archive.tellp();
 
 for(unsigned int i = 0; i < DstLength; i++)
 Archive << Dst;
 }
 else //... or uncompressed file.
 {
 cout << "No he can't!\r\n\r\n";
 
 m_Entries.Compressed = 0x00;
 
 for(int i = 0; i < size; i++)
 Archive << Dst;
 }
 
 delete Dst;
 delete MemBlock;
 delete Filename;
 CurrentFile.close();
 }
 
 ifstream::pos_type ManifestOffsetStart = Archive.tellp();
 
 for(unsigned int i = 0; i < m_NumFiles; i++)
 {
 Archive << m_Entries.DecompressedDataSize;
 //TODO: Write this as only 3 bytes!
 Archive << m_Entries.CompressedDataSize;
 Archive << m_Entries.DataType;
 Archive << m_Entries.DataOffset;
 Archive << m_Entries.Compressed;
 Archive << m_Entries.AccessNumber;
 Archive << m_Entries.FilenameLength;
 Archive << m_Entries.TypeID;
 Archive << m_Entries.FileID;
 
 //Note: Not entirely sure if this is the correct way to get the filename down...
 for(unsigned int j = 0; j < m_Entries.FilenameLength; j++)
 m_Entries.Filename[j];
 }
 }
 
 string Replace(string Str, string From, string To)
 {
 int Position = Str.find(From);
 
 while(Position != string::npos)
 {
 Str = Str.replace(Position, From.length(), To);
 Position = Str.find(From, Position + From.length());
 }
 
 return Str;
 }}

I'm using FreeImage to convert the images, and some black voodoo magic to recompress an archive.
Oh, and, in case you can't figure it out by looking at this code, here's what a FAR3 entry looks like:

struct FAR3Entry {
 unsigned int DecompressedDataSize;
 unsigned int CompressedDataSize; /* Only 3 bytes large; refers to the total data's size including the RefPack header */
 unsigned char DataType; /* Normally equals 0x80 to denote that the data is in a RefPack container */
 unsigned int DataOffset; /* Relative to the beginning of the FAR file */
 unsigned char Compressed; /* Normally equals 0x01 */
 unsigned char AccessNumber; /* Refers to the number of times that the data at the specified offset has been used for other entries: Normally equals 0x00 (and works its way up) */
 unsigned short FilenameLength; /* Note that the file name does not terminate with a null character */
 unsigned int TypeID;
 unsigned int FileID;
 char Filename[256];
 };

Lesson learned?
If you're trying to find the size of a 1,5kb file and end up allocating 3,9gigs for it, the file probably wasn't opened, or you did something wrong.

Topic Locked