[web] PHP warnings...

Not sure why the code boxes get [size=2] and [ b ] in them.

I think the [ code ][/ code ] tags are bugged...

The $_POST superglobal will only contain values of fields that have been POSTed to the page. To determine whether the values exist you can use isset:

if (isset($_POST['BtnSubmit'], $_POST['TxtFname'], $_POST['TxtPwd'])) {
# BtnSubmit, TxtFname and TxtPwd have been submitted - try logging on.
}

Historically, register_globals would put any incoming variables (whether they come from $_SERVER, $_POST, $_GET etc) into their own variables (so you could access $_POST['TxtFname'] as $TextFname). This feature (which is a bit of a security hole) has been switched off by default for a while now, so $PHP_SELF should be $_SERVER['PHP_SELF'].

Hm.
I changed my code to:



<?php
/* Created on: 16.03.2011 */
$TxtFname = $_POST["TxtFname"];
$TxtPwd = $_POST["TxtPwd"];

if (!isset($_POST["BtnSubmit"], $_POST['TxtFname'], $_POST['TxtPwd'])) //If form is not submitted to itself yet...
{
?>
<html>
<img src="Boligmagasinet - headding.jpg">
<link rel=stylesheet href="login-style.css">

<body>

<ul>
<li>Hjem</li>
<li>Om oss</li>
<li>Kontakt</li>
<li>Magasiner</li>
</ul>

<form method="post" action="<?php echo $_SERVER['PHP_SELF'];?>">
Brukernavn:<input type="text" size="20" maxlength="20" name="TxtFname">

Passord:<input type="text" size="20" maxlength="20" name="TxtPwd">


<input type="submit" value="Logg inn" name="BtnSubmit">


</form>
<?
}
else
{
//TODO: DB...
}
?>
</body>
</html>


but I still get the warnings :\

You are always trying to read from $_POST["TxtFname"], $_POST["TxtPwd"] even when they aren't set. The code to read them should go into the "else" branch.

Really?

I've been looking at a tutorial.

Is the code there old code?

Really?

I've been looking at a tutorial.

Is the code there old code?

Alot of php tutorials are just plain bad, (The same is true for language tutorials in general)

Hm, yeah, I guess.
I ended up just changing the form so it POSTed to a regular, plain php file. I didn't really get the whole concept of POSTing to itself.

When you grab variables from POST, REQUEST, or GET (or really, any array, but especially these ones), you need to check to see if the variable you re looking for was actually sent by the client. Get into the habit of doing this:

$foo = isset($_POST['foo']) ? $_POST['foo'] : NULL; // or some sane default

This avoids array index warnings. NEVER assume incoming data is what you would expect or that it is even present at all.

PS - and yes, 95%+ of PHP tutorials are awful.Everyone is an "expert"!