🔒 Locked

Wrong parameters order in constructor

Started by scypior Feb 4, 2009 at 6:15 PM 1 replies 1.4k views

Original Post

Feb 4, 2009 at 6:15 PM

Hello, I've encountered following issue: class Whatever { Whatever(uint x, uint y) { Log("X, Y: " + x + ", " + y); } } for(uint i = 0; i < 100; i ++) { Whatever whatever(i, i*10); } And the output is: X, Y: 0, 0 X, Y: 10, 1 X, Y: 20, 2 X, Y: 30, 3 and so on... The issue arose with latest revisions (349 and 350), but I've encountered it once before when tried to call constructor from constructor: class Cl { uint x; uint y; Cl(uint x) { Cl(x, 1); } Cl(uint x, uint y) { this.x = x; this.y = y; } }

WitchLord

Feb 5, 2009 at 6:53 AM

Thanks scypior,

You're absolutely right. I'll have this bug fixed right away.

AngelScript doesn't support calling another constructor from within a constructor. That syntax should have created a new instance of the object.

Regards,
Andreas

WitchLord

Feb 5, 2009 at 7:06 AM

The loop in asCCompiler::CompileFactory (as_compiler.cpp, line 187) was inverting the order of the arguments. The loop should be changed to the following:

int asCCompiler::CompileFactory(asCBuilder *builder, asCScriptCode *script, asCScriptFunction *outFunc){  ...	// Copy all arguments to the top of the stack	int argDwords = (int)outFunc->GetSpaceNeededForArguments();	for( int a = argDwords-1; a >= 0; a-- )		byteCode.InstrSHORT(BC_PshV4, -a);  ...}

I'll have this checked in as soon as possible.

Topic Locked

This topic has been locked by a moderator. New replies are not allowed.